Skip to content

Conversation

@uweigand
Copy link
Member

@uweigand uweigand commented Apr 9, 2025

Following-up on #10510 this adds the corresponding support to the s390x target.

Due to the separate ABI implementation, this currently needs to duplicate some of the underlying logic. I hope to be able to refactor ABI handling in the future to be able to share more of that code across all targets.

FYI @cfallin

Following-up on bytecodealliance#10510
this adds the corresponding support to the s390x target.

Due to the separate ABI implementation, this currently needs to
duplicate some of the underlying logic.  I hope to be able to
refactor ABI handling in the future to be able to share more of
that code across all targets.
@uweigand uweigand requested a review from a team as a code owner April 9, 2025 12:13
@uweigand uweigand requested review from cfallin and removed request for a team April 9, 2025 12:13
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language labels Apr 9, 2025
@github-actions
Copy link

github-actions bot commented Apr 9, 2025

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thanks for putting this together so quickly!

@cfallin cfallin added this pull request to the merge queue Apr 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 10, 2025
@cfallin cfallin added this pull request to the merge queue Apr 10, 2025
Merged via the queue into bytecodealliance:main with commit f1383ec Apr 10, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants