Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Wasmtime 23 #364

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Update to Wasmtime 23 #364

merged 2 commits into from
Aug 20, 2024

Conversation

jeffcharles
Copy link
Collaborator

Update to Wasmtime 23.0.2.

This enables the memory-protection-keys feature in Wasmtime so the pooling allocator configuration options that are gated by this feature can be used. Otherwise we would likely have to remove the API to enable using these configuration options. There haven't been any complaints about performance so keeping that logic in place should be fine.

The tests for the pooling allocator config have also been updated since Wasmtime no longer rounds up the value to a page size at configuration time but does it at runtime instead (see this commit message in Wasmtime for details).

@jeffcharles
Copy link
Collaborator Author

jeffcharles commented Aug 19, 2024

I think the build_doc step is failing because we're using nightly-2023-12-30 for that job and Wasmtime 23 requires at least Rust 1.77.0.

@saulecabrera saulecabrera merged commit 1f81c25 into main Aug 20, 2024
23 checks passed
@saulecabrera saulecabrera deleted the jc.wasmtime-23 branch August 20, 2024 09:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants