Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm-metadata] Split lib.rs into separate files #1917

Merged
merged 11 commits into from
Nov 28, 2024

Conversation

yoshuawuyts
Copy link
Member

@yoshuawuyts yoshuawuyts commented Nov 28, 2024

I'm planning to file a number of patches to wasm-metadata, but I realized those would probably be easier to review if I split the file into separate files first. This splits the original 1500+ line file into separate files library and test files. This PR intentionally does not include any logic changes, all code is otherwise left unmodified. Thanks!

edit: I guess I did add a one-line doc comment at the top of lib.rs. So technically that's one change :)

@yoshuawuyts
Copy link
Member Author

CI is failing because of #1918

@yoshuawuyts
Copy link
Member Author

Filed a fix for #1918 in #1919. Once that's been merged we can rebase this PR and CI should pass.

@yoshuawuyts
Copy link
Member Author

Looks like this should be good to merge now!

@yoshuawuyts yoshuawuyts changed the title Split wasm-metadata into separate files [wasm-metadata] Split lib.rs into separate files Nov 28, 2024
@alexcrichton alexcrichton added this pull request to the merge queue Nov 28, 2024
Merged via the queue into bytecodealliance:main with commit 33a8bd0 Nov 28, 2024
30 checks passed
@yoshuawuyts yoshuawuyts deleted the refactor-metadata branch November 29, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants