fix pointer unchecked issue in thread-mgr #960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Jan 14, 2022
| return NULL; | ||
| } | ||
|
|
||
| if (module_inst) { |
There was a problem hiding this comment.
module_inst is used to get module in Line 347, wasm_exec_env_get_module doesn't check whether module_inst is NULL or not.
Can we change L347 to wasm_module_t module;, and add checks for module_inst and module at the beginning, L353:
if (!module_inst || !(module = wasm_exec_env_get_module(module_inst))) {
return NULL;
}And here and L378, no need to check module_inst again
wenyongh
referenced
this pull request
in wenyongh/wasm-micro-runtime
Jan 14, 2022
Fix pointer unchecked issue in thread-mgr.c (#960)
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
And refine the code format of thread_manager.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.