fix duplicate debug instance id in multiple native thread issue #847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The debug_instance_list is not protected by mutex, and the debug instance use the length of this list as its id. If several threads create debug instance at the same time, they may get duplicate ids. This patch add mutex to protect this list
lum1n0us
reviewed
Nov 24, 2021
| static uint32 current_instance_id = 1; | ||
|
|
||
| static uint32 | ||
| allocate_instance_id() |
There was a problem hiding this comment.
how about GCC atomic builtins?
There was a problem hiding this comment.
I‘ve also considered this, but I concern about the compiler compatibility. The GCC atomic builtins are optional features so there may be some compiler who doesn't implement it.
Also, in my opinion, these codes are not on the critical path, the mutex lock should not raise performance issues
@wenyongh how do you think about this?
There was a problem hiding this comment.
Should not use the optional function which might lead to link error in some platform or compiler. Normally here we should use the API provided by platform layer.
wenyongh
reviewed
Nov 25, 2021
| memset(engine, 0, sizeof(WASMDebugEngine)); | ||
|
|
||
| if (os_mutex_init(&engine->instance_list_lock) != 0) { | ||
| LOG_ERROR("WASM Debug Engine error: failed to init mutex"); |
There was a problem hiding this comment.
Should free engine before return NULL
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…ecodealliance#847) The debug_instance_list is not protected by mutex, and the debug instance uses the length of this list as its id. If several threads create debug instance at the same time, they may get duplicated/same ids. This patch adds mutex to protect this list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug_instance_list is not protected by mutex, and the debug instance use
the length of this list as its id. If several threads create debug instance at
the same time, they may get duplicate ids. This patch add mutex to protect this
list