Set APP_THREAD_STACK_SIZE_DEFAULT of nuttx #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no1wudi
reviewed
Oct 12, 2021
| /* Default/min/max stack size of each app thread */ | ||
| #if !defined(BH_PLATFORM_ZEPHYR) && !defined(BH_PLATFORM_ALIOS_THINGS) \ | ||
| #ifdef BH_PLATFORM_NUTTX | ||
| #define APP_THREAD_STACK_SIZE_DEFAULT PTHREAD_STACK_DEFAULT |
Collaborator
There was a problem hiding this comment.
Does these macro defined in POSIX standard?
no1wudi
reviewed
Oct 12, 2021
| #define APP_THREAD_STACK_SIZE_DEFAULT PTHREAD_STACK_DEFAULT | ||
| #define APP_THREAD_STACK_SIZE_MIN PTHREAD_STACK_MIN | ||
| #else | ||
| #define APP_THREAD_STACK_SIZE_DEFAULT (32 * 1024) |
Collaborator
There was a problem hiding this comment.
Replace the hard coded size with PTHREAD_STACK_DEFAULT and PTHREAD_STACK_MIN on POSIX compatible system ?
Please take a look ? @wenyongh
Contributor
There was a problem hiding this comment.
How about change to:
#if defined(BH_PLATFORM_ZEPHYR) || defined(BH_PLATFORM_ALIOS_THINGS) \
|| defined(BH_PLATFORM_ESP_IDF) || defined(BH_PLATFORM_OPENRTOS)
#define APP_THREAD_STACK_SIZE_DEFAULT (6 * 1024)
#define APP_THREAD_STACK_SIZE_MIN (4 * 1024)
#elif defined(PTHREAD_STACK_DEFAULT) && defined(PTHREAD_STACK_MIN)
#define APP_THREAD_STACK_SIZE_DEFAULT PTHREAD_STACK_DEFAULT
#define APP_THREAD_STACK_SIZE_MIN PTHREAD_STACK_MIN
#else
#define APP_THREAD_STACK_SIZE_DEFAULT (32 * 1024)
#define APP_THREAD_STACK_SIZE_MIN (24 * 1024)
#endif
N/A Signed-off-by: zhouliang3 <[email protected]> Change-Id: I7ea16fdb91ea9bc9215a9dee7c983192d990b87c
wenyongh
referenced
this pull request
in wenyongh/wasm-micro-runtime
Oct 12, 2021
Set APP_THREAD_STACK_SIZE_DEFAULT/MIN for POSIX platforms (#779)
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…liance#779) Set APP_THREAD_STACK_SIZE_DEFAULT/MIN to PTHREAD_STACK_DEFAULT/MIN when the macros are defined. Signed-off-by: zhouliang3 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.