Unify iwasm implement for POSIX compatible system #675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Jul 29, 2021
Contributor
wenyongh
left a comment
wenyongh
left a comment
There was a problem hiding this comment.
Some main.c files are soft link files, right?
WAMR supports Windows platform and the repo may be cloned under Windows, using soft link file is not friendly for Windows, can we keep the original main.c file, and only add a line:
#include "../posix/main.c"
Signed-off-by: Huang Qi <[email protected]>
Collaborator
Author
Done |
wenyongh
referenced
this pull request
in wenyongh/wasm-micro-runtime
Jul 29, 2021
Unify product-mini main.c implementation for POSIX compatible system (#675)
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…ytecodealliance#675) Unify product-mini main.c implementation for POSIX compatible system: create a shared main.c under platforms/posix/main.c, and in other POSIX platforms' main.c, just keep a line "#include ../posix/main.c". Signed-off-by: Huang Qi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge iwasm for NuttX、Linux、Darwin、VxWorks into one since they are POSIX compatible with little difference, such as global heap pool size.