New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test:type matching issue and code redundancy #4079

Open

yangkun27 wants to merge 1 commit into bytecodealliance:main from yangkun27:local

yangkun27 commented Feb 12, 2025

This pull request contains some changes about unit test

In unit test wasm_vm.cc, it seems better to define the type of argv as uint32 to match the parameter of the function wasm_runtime_call_wasm.
In test interpreter_test.cc, ret = is redundant.


          Unit test:type matching issue and code redundancy

4f2653d

yangkun27 requested review from loganek, lum1n0us, no1wudi, TianlongLiang, wenyongh, xujuntwt95329 and yamt as code owners

February 12, 2025 07:58

no1wudi approved these changes

View reviewed changes

yangkun27 force-pushed the local branch from 29f17fe to 4f2653d Compare

February 12, 2025 11:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

no1wudi no1wudi approved these changes

loganek Awaiting requested review from loganek loganek is a code owner

lum1n0us Awaiting requested review from lum1n0us lum1n0us is a code owner

TianlongLiang Awaiting requested review from TianlongLiang TianlongLiang is a code owner

wenyongh Awaiting requested review from wenyongh wenyongh is a code owner

xujuntwt95329 Awaiting requested review from xujuntwt95329 xujuntwt95329 is a code owner

yamt Awaiting requested review from yamt yamt is a code owner

At least 2 approving reviews are required to merge this pull request.

Labels

None yet