Skip to content

In wasm32, fix potential conversion overflow when enlarging 65536 pages #4064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2025
Merged

In wasm32, fix potential conversion overflow when enlarging 65536 pages #4064

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e5f64f
fix enlarge 65536 pages conversion overflow in wasm32
TianlongLiang Feb 6, 2025
99d0576
cr suggestions
TianlongLiang Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/iwasm/common/wasm_memory.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1389,20 +1389,20 @@ wasm_enlarge_memory_internal(WASMModuleInstanceCommon *module,
if (full_size_mmaped) {
#ifdef BH_PLATFORM_WINDOWS
if (!os_mem_commit(memory->memory_data_end,
(mem_offset_t)(total_size_new - total_size_old),
total_size_new - total_size_old,
MMAP_PROT_READ | MMAP_PROT_WRITE)) {
ret = false;
goto return_func;
}
#endif

if (os_mprotect(memory->memory_data_end,
(mem_offset_t)(total_size_new - total_size_old),
total_size_new - total_size_old,
MMAP_PROT_READ | MMAP_PROT_WRITE)
!= 0) {
#ifdef BH_PLATFORM_WINDOWS
os_mem_decommit(memory->memory_data_end,
(mem_offset_t)(total_size_new - total_size_old));
total_size_new - total_size_old);
#endif
ret = false;
goto return_func;
Expand Down