Skip to content

Implement load lanes opcodes for wasm #3942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Implement load lanes opcodes for wasm #3942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions core/iwasm/interpreter/wasm_interp_fast.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6391,12 +6391,46 @@ wasm_interp_call_func_bytecode(WASMModuleInstance *module,
break;
}

// TODO:
/* load lane operations */
#define SIMD_LOAD_LANE_OP(register, width) \
do { \
uint32 offset, addr; \
offset = read_uint32(frame_ip); \
V128 vec = POP_V128(); \
int32 base = POP_I32(); \
offset += base; \
int lane = *frame_ip++; \
addr = GET_OPERAND(uint32, I32, 0); \
addr_ret = GET_OFFSET(); \
CHECK_MEMORY_OVERFLOW(width / 8); \
if (width == 64) { \
vec.register[lane] = GET_I64_FROM_ADDR(maddr); \
} \
else { \
vec.register[lane] = *(uint##width *)(maddr); \
} \
PUT_V128_TO_ADDR(frame_lp + addr_ret, vec); \
} while (0)

case SIMD_v128_load8_lane:
{
SIMD_LOAD_LANE_OP(i8x16, 8);
break;
}
case SIMD_v128_load16_lane:
{
SIMD_LOAD_LANE_OP(i16x8, 16);
break;
}
case SIMD_v128_load32_lane:
{
SIMD_LOAD_LANE_OP(i32x4, 32);
break;
}
case SIMD_v128_load64_lane:
{
SIMD_LOAD_LANE_OP(i64x2, 64);
break;
}
case SIMD_v128_store8_lane:
case SIMD_v128_store16_lane:
case SIMD_v128_store32_lane:
Expand Down
7 changes: 6 additions & 1 deletion core/iwasm/interpreter/wasm_loader.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15368,9 +15368,14 @@ wasm_loader_prepare_bytecode(WASMModule *module, WASMFunction *func,
error_buf_size)) {
goto fail;
}

#if WASM_ENABLE_FAST_INTERP != 0
emit_uint32(loader_ctx, mem_offset);
#endif
POP_V128();
POP_MEM_OFFSET();
#if WASM_ENABLE_FAST_INTERP != 0
emit_byte(loader_ctx, lane);
#endif
if (opcode1 < SIMD_v128_store8_lane) {
PUSH_V128();
}
Expand Down
Loading