Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore cmake hidden compile symbol visibility #3796

Merged

Conversation

bnason-nf
Copy link
Contributor

This was originally fixed in #3655, but regressed in #3762 which removed the -fvisibility=hidden flag from the CMakeLists.txt file.

This also removes extraneous ending whitespace from the file.

This was originally fixed in bytecodealliance#3655, but regressed in bytecodealliance#3762 which removed
the -fvisibility=hidden flag from the CMakeLists.txt file.

This also removes extraneous ending whitespace from the file.
@wenyongh wenyongh merged commit e9cc873 into bytecodealliance:main Sep 18, 2024
1 check passed
@bnason-nf bnason-nf deleted the restore-cmake-visibility-hidden branch September 18, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants