wamrc: Add --mllvm= option #3658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows users to specify llvm command line options similarly to clang's -mllvm option. my motivations: * -debug and friends * -mtext-section-literals for xtensa
wenyongh
reviewed
Jul 24, 2024
| @@ -738,6 +765,7 @@ main(int argc, char *argv[]) | |||
| if (option.custom_sections) { | |||
| free(option.custom_sections); | |||
| } | |||
| free(llvm_options); | |||
There was a problem hiding this comment.
Is it better to check llvm_options and free it only when it is not NULL? like L765
There was a problem hiding this comment.
When --mllvm=xxx isn't specified, llvm_options is NULL, no need to free it in fact. Though the linux manual of free says no operation is performed if ptr is NULL, I am not sure whether it is a good coding style, we usually free a buffer only when it is NULL. It is good if the same behavior is ensured in other platforms.
There was a problem hiding this comment.
free(NULL) is guaranteed to be a no-op by C language.
i'm not aware of any problematic platforms wrt that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows users to specify llvm command line options similarly to clang's -mllvm option.
my motivations: