Use another variable to check if in oss-fuzz environment #3518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Jun 12, 2024
| @@ -120,8 +120,11 @@ add_compile_options(-fsanitize=fuzzer) | |||
| add_link_options(-fsanitize=fuzzer) | |||
|
|
|||
| # if not calling from oss-fuzz helper, enable all support sanitizers | |||
| # oss-fuzz always defines `HELPER=True` | |||
| if (NOT "$ENV{HELPER}" STREQUAL "True") | |||
| # oss-fuzz will defines FUZZING_BUILD_MODE_UNSAFE_FOR_PRODUCTION in CFLAGS and CXXFLAGS | |||
There was a problem hiding this comment.
had better defines -> define
In order to pass a oss-fuzz build step *check_build*. Previous `HELPER` is only for local test.
lum1n0us
force-pushed
the
fix/check_if_oss_fuzz
branch
from
d451269
to
a49d733
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to pass a oss-fuzz build step check_build.
Previous
HELPERis only for local test.