Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated tests of language-bindings python #3018

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

wenyongh
Copy link
Contributor

After PR #2922, caller of wasm-c-api wasm_func_call should ensure
the params and results are correctly created, runtime doesn't check
their format again.

@lum1n0us
Copy link
Collaborator

let's just remove the code instead of...

@wenyongh wenyongh changed the title Comment some tests of language-bindings python Remove deprecated tests of language-bindings python Jan 16, 2024
@wenyongh
Copy link
Contributor Author

let's just remove the code instead of...

Yes, updated.

Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyongh wenyongh merged commit 705bf80 into bytecodealliance:main Jan 16, 2024
1 check passed
@wenyongh wenyongh deleted the fix_lang_bind_go branch January 19, 2024 12:38
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
…#3018)

After PR bytecodealliance#2922, the caller of wasm-c-api wasm_func_call should ensure
the params and results are correctly created, runtime doesn't check
their format again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants