Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor clock functions to use WASI types #2666

Merged

Conversation

zoraaver
Copy link
Contributor

Refactoring the clock functions to use WASI types so we can simplify the code and remove some unnecessary boilerplate. See
#2637 (comment) for details.

@zoraaver zoraaver force-pushed the wasi-clock-refactor branch 2 times, most recently from 3442d2e to 3c53fa7 Compare October 24, 2023 11:52
@zoraaver zoraaver force-pushed the wasi-clock-refactor branch 2 times, most recently from 6b1c42c to 7a5d3de Compare October 24, 2023 15:09
Copy link
Collaborator

@loganek loganek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wenyongh wenyongh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, could you resolve the conflict issues introduced by the merging of last PR?

@zoraaver zoraaver force-pushed the wasi-clock-refactor branch from 7a5d3de to c12e071 Compare October 25, 2023 08:38
Refactoring the clock functions to use WASI types so we can simplify the
code and remove some unnecessary boilerplate. See
bytecodealliance#2637 (comment)
for details.
@zoraaver zoraaver force-pushed the wasi-clock-refactor branch from c12e071 to 1c63c80 Compare October 25, 2023 08:43
@zoraaver
Copy link
Contributor Author

I've rebased and resolved the conflicts

@wenyongh wenyongh merged commit e7a62d2 into bytecodealliance:dev/wasi-libc-windows Oct 25, 2023
381 checks passed
@zoraaver zoraaver deleted the wasi-clock-refactor branch October 25, 2023 11:47
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Refactoring the clock functions to use WASI types so we can simplify the
code and remove some unnecessary boilerplate. See
bytecodealliance#2637 (comment)
for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants