Partial windows filesystem implementation #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoraaver
force-pushed
the
windows-partial-filesystem
branch
from
88ec209 to
a36f48d
Compare
loganek
reviewed
Oct 20, 2023
loganek
reviewed
Oct 20, 2023
zoraaver
force-pushed
the
windows-partial-filesystem
branch
4 times, most recently
from
96e4fa2 to
2087533
Compare
|
@wenyongh would you be able to take a look at this PR? thanks |
loganek
reviewed
Oct 23, 2023
loganek
reviewed
Oct 23, 2023
loganek
reviewed
Oct 23, 2023
loganek
reviewed
Oct 23, 2023
zoraaver
force-pushed
the
windows-partial-filesystem
branch
from
2087533 to
65e314e
Compare
wenyongh
reviewed
Oct 24, 2023
Comment on lines
+340
to
+335
| wchar_t extension[256]; | ||
| wchar_t filename[256]; |
There was a problem hiding this comment.
Buffer size of filename may be a little small?
There was a problem hiding this comment.
Going by https://learn.microsoft.com/en-gb/windows/win32/fileio/maximum-file-path-limitation?tabs=registry, the max filename length is 256 characters.
zoraaver
force-pushed
the
windows-partial-filesystem
branch
from
65e314e to
35e5793
Compare
Implement the necessary os_ filesystem functions to enable successful WASI initialisation on Windows. Some small changes were also required to the sockets implementation to use the new windows_handle type. The remaining functions will be implemented in a future PR.
zoraaver
force-pushed
the
windows-partial-filesystem
branch
from
35e5793 to
a719c75
Compare
wenyongh
reviewed
Oct 25, 2023
Comment on lines
+340
to
+335
| wchar_t extension[256]; | ||
| wchar_t filename[256]; |
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Implement the necessary os_ filesystem functions to enable successful WASI initialization on Windows. Some small changes were also required to the sockets implementation to use the new windows_handle type. The remaining functions will be implemented in a future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the necessary os_ filesystem functions to enable successful WASI initialisation on Windows. Some small changes were also required to the sockets implementation to use the new windows_handle type. The remaining functions will be implemented in a future PR.