Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix windows link error and clear windows warnings #2463

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Fix windows link error and clear windows warnings #2463

merged 2 commits into from
Aug 14, 2023

Conversation

wenyongh
Copy link
Contributor

  • Fix windows wamrc link error: aot_generate_tempfile_name undefined.
  • Clear windows compile warnings.
  • And rename folder samples/bh_atomic and samples/mem_allocator to
    samples/bh-atomic and samples/mem-allocator.

@wenyongh wenyongh changed the title Fix windows link error and clear win warnings Fix windows link error and clear windows warnings Aug 14, 2023
yamt
yamt approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@yamt yamt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wenyongh wenyongh merged commit 923e8d6 into bytecodealliance:main Aug 14, 2023
@wenyongh wenyongh deleted the fix_win_issues branch August 15, 2023 04:23
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@wenyongh
Fix windows link error and clear windows warnings (bytecodealliance#2463
d7da3b4 
)

- Fix windows wamrc link error: aot_generate_tempfile_name undefined.
- Clear windows compile warnings.
- And rename folder `samples/bh_atomic` and `samples/mem_allocator` to
  `samples/bh-atomic` and `samples/mem-allocator`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yamt yamt yamt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wenyongh @yamt