aot: disable musttail for mips #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While i'm not familiar with mips abi, it's reported that it (at least sometimes) doesn't work. This fixes bytecodealliance#2412
|
I'm not familiar with the context so the questions can be silly enough:
By the way, we have MIPS env so we can help with testing this PR if it's needed |
stack check logic has been moved to a separate function for better estimation. in 1.2.2, stack check logic were sprinkled in user functions inline. i expect some performance penalty, comparing to 1.2.2.
it's welcome. |
Zzzabiyaka
pushed a commit
to Zzzabiyaka/wasm-micro-runtime
that referenced
this pull request
Aug 15, 2023
Zzzabiyaka
pushed a commit
to Zzzabiyaka/wasm-micro-runtime
that referenced
this pull request
Aug 15, 2023
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While i'm not familiar with mips abi, it's reported that it (at least sometimes) doesn't work.
This fixes #2412