Implement wasm_externref_objdel and wasm_externref_set_cleanup
#2455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonibofarull
force-pushed
the
tbc/add-externref-helpers
branch
from
a300e68 to
caa20f5
Compare
tonibofarull
force-pushed
the
tbc/add-externref-helpers
branch
from
caa20f5 to
0b3142b
Compare
wenyongh
reviewed
Aug 14, 2023
tonibofarull
changed the title
wasm_externref_objdel and wasm_externref_add_cleanupwasm_externref_objdel and wasm_externref_set_cleanup
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…ytecodealliance#2455) ## Context Some native libraries may want to explicitly delete an externref object without waiting for the module instance to be deleted. In addition, it may want to add a cleanup function. ## Proposed Changes Implement: * `wasm_externref_objdel` to explicitly delete an externeref'd object. * `wasm_externref_set_cleanup` to set a cleanup function that is called when the externref'd object is deleted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Some native libraries may want to explicitly delete an externref object without waiting for the module instance to be deleted.
In addition, it may want to add a cleanup function.
Proposed Changes
Implement:
wasm_externref_objdelto explicitly delete an externeref'd object.wasm_externref_add_cleanupto add a cleanup function that is called when the externref'd object is deleted.Acknowledgments
Thanks to @rvargas-midokura for the implementation!