Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid switch lowering to lookup tables for XIP #2339

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

yamt
Copy link
Collaborator

@yamt yamt commented Jul 4, 2023

Because it involves relocations for the table. (.Lswitch.table.XXX)

Discussions: #2316

Because it involves relocations for the table. (.Lswitch.table.XXX)
@yamt yamt marked this pull request as ready for review July 4, 2023 06:48
@yamt
Copy link
Collaborator Author

yamt commented Jul 4, 2023

i tested that this avoids switch-table relocations in the "br_table" test case for riscv32.
(merely tested with #2340, not with riscv32 iwasm.)

@wenyongh wenyongh merged commit 1f89e44 into bytecodealliance:main Jul 4, 2023
victoryang00 pushed a commit to victoryang00/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Because it involves relocations for the table. (.Lswitch.table.XXX)

Discussions: bytecodealliance#2316
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants