Rename thread_spawn import #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the wit-defined ABI: WebAssembly/wasi-threads#26 cf. WebAssembly/wasi-libc#387
yamt
force-pushed
the
rename-thread-spawn
branch
from
95f98fc
to
7e2c6c0
Compare
yamt
force-pushed
the
rename-thread-spawn
branch
from
7e2c6c0
to
193f11d
Compare
yamt
force-pushed
the
rename-thread-spawn
branch
3 times, most recently
from
905a004
to
aeb17ec
Compare
As far as I know, cmake can't handle two different compilers and targets within a project as this sample is trying to do. This commit is a band-aid fix. While CMAKE_C_COMPILER_TARGET here happens to work when both of host compiler and wasm compiler are clang, it doesn't seem working if the host compiler is gcc. (as it is on the linux jobs on the CI.)
yamt
force-pushed
the
rename-thread-spawn
branch
from
aeb17ec
to
b9947b2
Compare
victoryang00
pushed a commit
to victoryang00/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Following the wit-defined ABI: WebAssembly/wasi-threads#26 cf. WebAssembly/wasi-libc#387
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the wit-defined ABI:
WebAssembly/wasi-threads#26
cf. WebAssembly/wasi-libc#387