Quit if meeting unimport globals #1859
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
force-pushed
the
quit_if_meet_unimport
branch
2 times, most recently
from
d63314b to
7cf9829
Compare
lum1n0us
changed the title
wenyongh
reviewed
Jan 5, 2023
core/iwasm/aot/aot_runtime.c
Outdated
Comment on lines
989
to
990
| LOG_WARNING("warning: failed to link import global (%s, %s)", | ||
| global->module_name, global->global_name); |
Contributor
There was a problem hiding this comment.
Should be an error here, use set_error_buf
Comment on lines
1254
to
1255
| LOG_WARNING("warning: failed to link import global (%s, %s)", | ||
| global->module_name, global->field_name); |
Contributor
There was a problem hiding this comment.
Same as above, should be an error
There are warning for unimport functions
lum1n0us
force-pushed
the
quit_if_meet_unimport
branch
from
7cf9829 to
7308d80
Compare
NingW101
pushed a commit
to NingW101/wasm-micro-runtime
that referenced
this pull request
Jan 11, 2023
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.