Add memory watchpoint support to debugger #1762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cimacmillan
force-pushed
the
cmmacmil/watchpoint
branch
from
eb07704 to
eda30d6
Compare
wenyongh
reviewed
Dec 2, 2022
cimacmillan
force-pushed
the
cmmacmil/watchpoint
branch
from
eda30d6 to
6f83211
Compare
wenyongh
reviewed
Dec 6, 2022
Contributor
wenyongh
left a comment
wenyongh
left a comment
There was a problem hiding this comment.
@cimacmillan Only a comment left from me, could you help modify the code again? Thanks.
Comment on lines
+98
to
+99
| #define CHECK_READ_WATCHPOINT(addr, offset) | ||
| #define CHECK_WRITE_WATCHPOINT(addr, offset) |
Contributor
There was a problem hiding this comment.
Had better define them as (void)0, or when it is called with CHECK_READ_WATCHPOINT(addr, offset);, there will be a single ; after extended, and may cause compile warning.
Contributor
Author
There was a problem hiding this comment.
Good catch thanks
wenyongh
added a commit
to wenyongh/wasm-micro-runtime
that referenced
this pull request
Dec 8, 2022
Add memory watchpoint support for source debugger (bytecodealliance#1762)
wenyongh
pushed a commit
that referenced
this pull request
Dec 19, 2022
Allow to add watchpoints to variables for source debugging. For instance: `breakpoint set variable var` will pause WAMR execution when the address at var is written to. Can also set read/write watchpoints by passing r/w flags. This will pause execution when the address at var is read: `watchpoint set variable -w read var` Add two linked lists for read/write watchpoints. When the debug message handler receives a watchpoint request, it adds/removes to one/both of these lists. In the interpreter, when an address is read or stored to, check whether the address is in these lists. If so, throw a sigtrap and suspend the process.
wenyongh
pushed a commit
that referenced
this pull request
Dec 19, 2022
Allow to add watchpoints to variables for source debugging. For instance: `breakpoint set variable var` will pause WAMR execution when the address at var is written to. Can also set read/write watchpoints by passing r/w flags. This will pause execution when the address at var is read: `watchpoint set variable -w read var` Add two linked lists for read/write watchpoints. When the debug message handler receives a watchpoint request, it adds/removes to one/both of these lists. In the interpreter, when an address is read or stored to, check whether the address is in these lists. If so, throw a sigtrap and suspend the process.
wenyongh
pushed a commit
that referenced
this pull request
Dec 20, 2022
Allow to add watchpoints to variables for source debugging. For instance: `breakpoint set variable var` will pause WAMR execution when the address at var is written to. Can also set read/write watchpoints by passing r/w flags. This will pause execution when the address at var is read: `watchpoint set variable -w read var` Add two linked lists for read/write watchpoints. When the debug message handler receives a watchpoint request, it adds/removes to one/both of these lists. In the interpreter, when an address is read or stored to, check whether the address is in these lists. If so, throw a sigtrap and suspend the process.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
) Allow to add watchpoints to variables for source debugging. For instance: `breakpoint set variable var` will pause WAMR execution when the address at var is written to. Can also set read/write watchpoints by passing r/w flags. This will pause execution when the address at var is read: `watchpoint set variable -w read var` Add two linked lists for read/write watchpoints. When the debug message handler receives a watchpoint request, it adds/removes to one/both of these lists. In the interpreter, when an address is read or stored to, check whether the address is in these lists. If so, throw a sigtrap and suspend the process.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
) Allow to add watchpoints to variables for source debugging. For instance: `breakpoint set variable var` will pause WAMR execution when the address at var is written to. Can also set read/write watchpoints by passing r/w flags. This will pause execution when the address at var is read: `watchpoint set variable -w read var` Add two linked lists for read/write watchpoints. When the debug message handler receives a watchpoint request, it adds/removes to one/both of these lists. In the interpreter, when an address is read or stored to, check whether the address is in these lists. If so, throw a sigtrap and suspend the process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added memory watchpoint support to the WAMR debug engine
Why
This allows us to add watchpoints to variables for debugging. For instance:
Will pause WAMR execution when the address at
varis written to. You can also set read (and r/w) watchpoints by passing this flag. This will pause execution when the address at var is read.How
Added two linked lists for read/write watchpoints. When the debug message handler receives a watchpoint request, it adds/removes to one/both of these lists. In the interpreter, when an address is read or stored to, check whether the address is in these lists. If so, throw a sigtrap and suspend the process.
This can support an arbitrary number of watchpoints. But there's some tradeoff that the more watchpoints, the more checks. This could be improved with a hashmap, although I think a small number of watchpoints (1 or 2) would be typical for most debugging sessions.