Skip to content

Conversation

@dongsheng28849455
Copy link
Contributor

Fix the issue that xtensa .aot size cannot be over 256K

Fix the issue that xtensa .aot size cannot be over 256K
set_error_buf(
error_buf, error_buf_size,
"AOT module load failed: "
"target address out of range. \r\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had better remove the trailing spaces: "target address out of range.\r\n"

error_buf, error_buf_size,
"AOT module load failed: "
"target address out of range. \r\n"
"use --size-level=0 option to generate .literal island");
Copy link
Contributor

@wenyongh wenyongh Nov 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing to

Try using `wamrc --size-level=0` to generate .literal island

To make it clearer

update space and description in prompt information
error_buf, error_buf_size,
"AOT module load failed: "
"target address out of range.\n"
"Try using `wamrc --size-level=0` to generate .literal island");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long, code guideline CI ran failed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, update again

Code guideline CI ran failed.
@wenyongh wenyongh merged commit c4defb8 into bytecodealliance:main Nov 24, 2022
NingW101 pushed a commit to NingW101/wasm-micro-runtime that referenced this pull request Dec 1, 2022
Fix the issue that xtensa .aot size cannot be over 256K.
wenyongh pushed a commit that referenced this pull request Dec 6, 2022
Fix the issue that xtensa .aot size cannot be over 256K.
wenyongh pushed a commit that referenced this pull request Dec 19, 2022
Fix the issue that xtensa .aot size cannot be over 256K.
vickiegpt pushed a commit to vickiegpt/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
Fix the issue that xtensa .aot size cannot be over 256K.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants