wrap wasi_socket_ext api with extern "C"
#1575
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganek
approved these changes
Oct 10, 2022
wenyongh
reviewed
Oct 11, 2022
Comment on lines
143
to
145
| #ifdef __cplusplus | ||
| extern "C" { | ||
| #endif |
Contributor
There was a problem hiding this comment.
A little strange that the macro only covers part of the code, prefer to wrap the whole file:
#ifndef _WASI_SOCKET_EXT_H_
#define _WASI_SOCKET_EXT_H_
#include <stdbool.h>
#include <stddef.h>
#include <stdint.h>
#ifdef __cplusplus
extern "C" {
#endif
=> leave an empty line
...
=> leave an empty line
#ifdef __cplusplus
}
#endif
=> leave an empty line
#endif /* end of _WASI_SOCKET_EXT_H_ */
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
Fix wasi_socket_ext library failed to link with cxx project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed wasi_socket_ext library failed to link with cxx project.