Skip to content

Conversation

@TianlongLiang
Copy link
Collaborator

combine three spec-test jobs into one, speed up workflow compilation_on_android_ubuntu.yml
TODO: the change is based on #1543 , after merging need to rebase

if: steps.cache_llvm.outputs.cache-hit != 'true'
run: echo "::error::can not get prebuilt llvm libraries" && exit 1

- name: install Ninja and x32 support libraries
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions:

  • only download llvm libraries in jit and aot mode
  • only install x32 support libraries when to run x86_32 cases

@TianlongLiang TianlongLiang force-pushed the ci_test_spec_alternative branch from e03e2a8 to f27ae0f Compare October 9, 2022 09:02
working-directory: ./tests/wamr-test-suites

spec_test_extra:
spec_test_all_in_one:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI for this file isn't trigged, we should remove line 14 and line 22 in this file. it should be bugs of this file (and same for several other files). Don't remember why we add them to ignore list of pull request and push.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it on my forked repo, and although it's fine, maybe I should wait for #1566 merge, and I will rebase again.

@TianlongLiang TianlongLiang force-pushed the ci_test_spec_alternative branch from f27ae0f to 6908e70 Compare October 10, 2022 05:21
@wenyongh wenyongh merged commit a226c65 into bytecodealliance:dev/binary_release Oct 10, 2022
@TianlongLiang TianlongLiang deleted the ci_test_spec_alternative branch October 11, 2022 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants