Socket: Explicit narrowing type cast and add missing static keywords. #1539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganek
requested changes
Sep 29, 2022
loganek
reviewed
Sep 29, 2022
…ccept. Co-authored-by: Marcin Kolny <[email protected]>
wenyongh
reviewed
Sep 29, 2022
loganek
approved these changes
Sep 29, 2022
wenyongh
added a commit
to wenyongh/wasm-micro-runtime
that referenced
this pull request
Sep 29, 2022
socket: Explicit narrowing type cast and add missing static keywords (bytecodealliance#1539)
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…ytecodealliance#1539) While compiling the file wasi_socket_ext.c with pedantic options (typically `-Wimplicit-int-conversion` and `-Wmissing-prototypes`), some warnings are raised. This PR addresses those warnings by adding missing static statements before functions and explicitly casting a narrowing conversion. And fix the error handling after calling getpeername.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear WAMR developers,
While compiling the file
wasi_socket_ext.cwith pedantic options (typically-Wimplicit-int-conversion,-Wmissing-prototypes), some warnings are raised.This PR addresses those warnings by adding missing
staticstatements before functions and explicitly casting a narrowing conversion.Cheers