AOT: fix crash in dumping call stack when the AOT file doesn't contain custom name section #1508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Sep 20, 2022
core/iwasm/aot/aot_runtime.c
Outdated
Comment on lines
2920
to
2921
| if (!func_names || !func_indexes || func_index_count == 0) | ||
| return NULL; |
Contributor
There was a problem hiding this comment.
We used to define the variables at the beginning of a { .. } as it is C source code, could you move the check to be ahead of L2925?
Contributor
Author
There was a problem hiding this comment.
OK, I have normalized it
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…n custom name section (bytecodealliance#1508)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.