Fix: thread-mgr: prevent an already detached thread from being detached again #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
reviewed
Sep 15, 2022
Comment on lines
700
to
701
| if (exec_env->thread_is_detached) | ||
| return 0; |
Contributor
There was a problem hiding this comment.
Should move the code into the lock/unlock code piece, e.g. :
os_mutex_lock(&cluster_list_lock);
if (exec_env->thread_is_detached) {
os_mutex_unlock(&cluster_list_lock);
return 0;
}
if (!clusters_have_exec_env(exec_env)) {
...
os_mutex_unlock(&cluster_list_lock);Or if another thread changes the state when current thread runs between L701 and L705, current thread will change again.
Contributor
Author
There was a problem hiding this comment.
OK, I have moved it into lock protection.
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…ain (bytecodealliance#1487) If WASM app has called pthread_detach() to detach a thread, it will be detached again when thread exits. Attempting to detach an already detached thread may result in crash in musl-libc. This patch fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If WASM app has called pthread_detach() to detach a thread, it will be detached again at thread exit. Attempting to detach an already detached thread results crash in musl-libc. This patch will fix it.