Add check for code section size, fix interp float operations #1480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyongh
changed the title
This was referenced Sep 13, 2022
wenyongh
changed the title
| loader_ctx->frame_ref -= 2; | ||
| loader_ctx->stack_cell_num -= 2; | ||
| #if (WASM_ENABLE_FAST_INTERP == 0) || (WASM_ENABLE_JIT != 0) | ||
| #if WASM_ENABLE_FAST_INTERP == 0 |
Collaborator
There was a problem hiding this comment.
Why we need to remove WASM_ENABLE_JIT != 0 here?
Contributor
Author
There was a problem hiding this comment.
The classic interpreter is enabled when LLVM JIT is enabled, no need to add the macro control again.
wenyongh
added a commit
to wenyongh/wasm-micro-runtime
that referenced
this pull request
Sep 15, 2022
Add check for code section size, fix interp float operations (bytecodealliance#1480)
vickiegpt
pushed a commit
to vickiegpt/wamr-aot-gc-checkpoint-restore
that referenced
this pull request
May 27, 2024
…ealliance#1480) And enable classic interpreter instead fast interpreter when llvm jit is enabled, so as to fix the issue that llvm jit cannot handle opcode drop_64/select_64.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.