Skip to content

esp-idf: Make esp-idf supports Libc WASI #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 15, 2022
Merged

esp-idf: Make esp-idf supports Libc WASI #1356

merged 3 commits into from
Aug 15, 2022
+265 −7

Conversation

@donghengqaz
Copy link
Contributor

@donghengqaz donghengqaz commented Aug 5, 2022 •
edited
Loading

esp-idf: Make esp-idf supports Libc WASI

  1. Support to get WASM APP libs' DIR from upper layer
  2. Add SSP support for esp-idf platform
  3. Change the errno of readlinkat

@donghengqaz donghengqaz force-pushed the feature/esp-idf_support_ssp branch from fc7ef44 to 592b442 Compare August 5, 2022 07:46
@wenyongh
Copy link
Contributor

wenyongh commented Aug 6, 2022

@donghengqaz, Thanks for uploading the PR! @loganek is also extending support for socket APIs, see #1336,
currently the development branch is dev/socket, and there are already some patches merged.
It seems that your PR has duplicated changes with them. Could you please split your PR into two parts: changes for socket and changes for non-socket? And for the former part, please submit it into dev/socket also, for the latter part, please submit it to the main branch.

@donghengqaz
Copy link
Contributor Author

donghengqaz commented Aug 8, 2022

@donghengqaz, Thanks for uploading the PR! @loganek is also extending support for socket APIs, see #1336, currently the development branch is dev/socket, and there are already some patches merged. It seems that your PR has duplicated changes with them. Could you please split your PR into two parts: changes for socket and changes for non-socket? And for the former part, please submit it into dev/socket also, for the latter part, please submit it to the main branch.

@wenyongh thanks for your advice, and I will do as you mentioned.

@wujiangang @donghengqaz
cmake: Support to get WASM APP libs' DIR from upper layer
cd2a39b 
WASM APP libs' DIR is set inside a function, cannot be gotten from the upper layer. For the platform such as IDF, users need to get this DIR and include it manually.
@donghengqaz donghengqaz force-pushed the feature/esp-idf_support_ssp branch from 35e8bf7 to 899d4fe Compare August 8, 2022 08:18
@donghengqaz donghengqaz force-pushed the feature/esp-idf_support_ssp branch from 899d4fe to 2c5bb53 Compare August 11, 2022 03:34
wenyongh
wenyongh reviewed Aug 12, 2022
View reviewed changes
@donghengqaz donghengqaz force-pushed the feature/esp-idf_support_ssp branch from 2c5bb53 to dae3d47 Compare August 15, 2022 06:31
@wenyongh wenyongh merged commit 071b8c2 into bytecodealliance:main Aug 15, 2022
@donghengqaz donghengqaz deleted the feature/esp-idf_support_ssp branch August 16, 2022 03:27
loganek pushed a commit to loganek/wasm-micro-runtime that referenced this pull request Aug 31, 2022
@donghengqaz @loganek
esp-idf: Make esp-idf support Libc WASI (bytecodealliance#1356)
6cdf5c7 
esp-idf: Make esp-idf support Libc WASI

1. Support to get WASM APP libs' DIR from upper layer
2. Add SSP support for esp-idf platform
3. Change the errno of readlinkat
yamt
yamt reviewed May 20, 2024
View reviewed changes
core/iwasm/libraries/libc-wasi/sandboxed-system-primitives/src/ssp_config.h
#if (defined(__linux__) || defined(ESP_PLATFORM)) \
&& (!defined(__GLIBC__) || __GLIBC__ > 2 \
|| (__GLIBC__ == 2 && __GLIBC_MINOR__ >= 25))
#define CONFIG_HAS_GETRANDOM 1
Copy link
Collaborator

@yamt yamt May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@donghengqaz
is this glibc version check really relevant to esp-idf?

Copy link
Contributor Author

@donghengqaz donghengqaz May 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very old modification, I added this to avoid compiling errors.

vickiegpt pushed a commit to vickiegpt/wamr-aot-gc-checkpoint-restore that referenced this pull request May 27, 2024
@donghengqaz
esp-idf: Make esp-idf support Libc WASI (bytecodealliance#1356)
a9a486b 
esp-idf: Make esp-idf support Libc WASI

1. Support to get WASM APP libs' DIR from upper layer
2. Add SSP support for esp-idf platform
3. Change the errno of readlinkat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yamt yamt yamt left review comments

@wenyongh wenyongh wenyongh left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@donghengqaz @wenyongh @yamt @wujiangang @lhespress