Refine socket-api sample #1040
Merged
Refine socket-api sample #1040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lum1n0us
reviewed
Mar 10, 2022
| printf("[Server] Shuting down ... \n"); | ||
| printf("[Server] Shuting down ..\n"); | ||
| shutdown(socket_fd, SHUT_RDWR); | ||
| close(socket_fd); |
There was a problem hiding this comment.
either shutdown or close, both are too much
lum1n0us
reviewed
Mar 10, 2022
samples/socket-api/README.md
Outdated
| Start the tcp client, which connects the server and receives message. | ||
| ```bash | ||
| cd build | ||
| ./iwasm --addr-pool=0.0.0.0/15 tcp_client.wasm |
lum1n0us
reviewed
Mar 10, 2022
samples/socket-api/README.md
Outdated
| Start the tcp server, which opens port 1234 and waits for clients to connect. | ||
| ```bash | ||
| cd build | ||
| ./iwasm --addr-pool=127.0.0.1/15 tcp_server.wasm |
There was a problem hiding this comment.
The server should use 0.0.0.0 to allow it to bind to any address. Partially because the code is use 0.0.0.0.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refine the source code of tcp_server.c and tcp_client.c
Add building of iwasm with lib-pthread and libc-wasi enabled
Add sample document
Update iwasm --addr-pool argument description