-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wit-bindgen and bump to 0.13.0 #81
Conversation
This commit updates wit-bindgen to 0.21.0 which brings in some minor updates to generated code in addition to a new `wit-bindgen-rt` crate dependency to use as well. This avoids the need to depend on the `wit-bindgen` crate at all through some updated options to the CLI bindings generator. Additionally this bumps the crate to 0.13.0 to release these updated change in addition to the refactoring for the export-related macros previously.
What is the advantage of not depending on |
Oh no real advantage per-se, but I figure it's at least a bit nicer in terms of "fewer deps" and better aligns with what cargo component is doing. AFAIK there's no technical benefit for doing so. |
Why is wit-bindgen-rt a separate crate? Would it make sense to just fold it into wit-bindgen? |
That was motivated by bytecodealliance/cargo-component#241 where I believe the issue was that |
As of bytecodealliance#81, this rustfmt-bindings.toml file is no longer used.
As of #81, this rustfmt-bindings.toml file is no longer used.
This commit updates wit-bindgen to 0.21.0 which brings in some minor updates to generated code in addition to a new
wit-bindgen-rt
crate dependency to use as well. This avoids the need to depend on thewit-bindgen
crate at all through some updated options to the CLI bindings generator.Additionally this bumps the crate to 0.13.0 to release these updated change in addition to the refactoring for the export-related macros previously.