Update to the latest wit-bindgen
#113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Minor preparations for hopeful inclusion into libstd * Reexport the new `bitflags` feature
|
Opening as a draft to test things before publishing a new wit-bindgen. |
|
I've also included a monstrosity of a sed script for #112 |
sunfishcode
reviewed
Aug 27, 2025
| sed -z -i 's/#\[unsafe(\n link_section = "\(.*\)"\n)\]/\ | ||
| #[cfg_attr(feature = "rustc-dep-of-std", unsafe(link_section = "\1-in-libstd"))]\ | ||
| #[cfg_attr(not(feature = "rustc-dep-of-std"), unsafe(link_section = "\1"))]\ | ||
| /' $file |
There was a problem hiding this comment.
Can you use wit-bindgen's --type-section-suffix flag to add the suffix?
There was a problem hiding this comment.
Oh we actually already use it but the problem here is that it needs a different suffix depending on whether rustc-dep-of-std is enabled or not (to have one name when depended on by libstd and another name when normally used from crates.io)
pchickey
approved these changes
Aug 27, 2025
alexcrichton
added a commit
to alexcrichton/rust-wasi
that referenced
this pull request
Aug 27, 2025
Mostly looking to integrate bytecodealliance#113 into the Rust standard library.
Merged
alexcrichton
added a commit
that referenced
this pull request
Aug 28, 2025
Mostly looking to integrate #113 into the Rust standard library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bitflagsfeature