Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support wasm32-unknown-wasi and x86_64-apple-macosx10.7.0 #14

Merged
merged 5 commits into from
Jul 9, 2019
Merged

Support wasm32-unknown-wasi and x86_64-apple-macosx10.7.0 #14

merged 5 commits into from
Jul 9, 2019

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented May 11, 2019

No description provided.

bjorn3 added a commit to rust-lang/rustc_codegen_cranelift that referenced this pull request May 11, 2019
@bjorn3
Partial support for wasm32-unknown-wasi as host triple
0046ce4 
This needs a rustc compiled for wasi (see rust-lang/miri#722)
It also needs bytecodealliance/target-lexicon#14
sunfishcode
sunfishcode reviewed May 11, 2019
View reviewed changes
src/targets.rs Outdated Show resolved Hide resolved
@sunfishcode
Copy link
Member

Also, we should teach Triple::default_calling_convention about Wasi. We can either use SystemV or make a new Wasm calling convention.

@bjorn3 bjorn3 changed the title Support wasm32-unknown-wasi Support wasm32-unknown-wasi and x86_64-apple-macosx10.7.0 Jun 23, 2019
@bjorn3
Copy link
Contributor Author

bjorn3 commented Jun 23, 2019

I added support for triples like x86_64-apple-macosx10.7.0, which rustc uses as llvm triple since rust-lang/rust#60788. I currently workaround this in cg_clif by replacing triples starting with x86_64-apple-macosx with x86_64-apple-darwin.

@bnjbvr bnjbvr requested a review from sunfishcode June 24, 2019 16:11
sunfishcode
sunfishcode reviewed Jun 24, 2019
View reviewed changes
src/targets.rs Show resolved Hide resolved
src/targets.rs Show resolved Hide resolved
@bnjbvr bnjbvr requested a review from sunfishcode July 8, 2019 13:25
sunfishcode
sunfishcode reviewed Jul 9, 2019
View reviewed changes
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@sunfishcode sunfishcode merged commit fd21542 into bytecodealliance:master Jul 9, 2019
@bjorn3 bjorn3 deleted the patch-1 branch July 9, 2019 05:02
@bjorn3 bjorn3 mentioned this pull request Aug 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunfishcode sunfishcode sunfishcode left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjorn3 @sunfishcode