Add more cargo:rerun-if-env-changed's to build.rs
#544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more `cargo:rerun-if-env-changed`'s to build.rs for rustix's features, configuration flags, and the toolchain variables rustix uses for autoconfiguration, to hopefully ensure it gets rerun when anything changes. See also #526.
jyn514
approved these changes
Feb 24, 2023
| println!("cargo:rerun-if-env-changed=CARGO_FEATURE_ALL_IMPLS"); | ||
| println!("cargo:rerun-if-env-changed=CARGO_CFG_MIRI"); | ||
| println!("cargo:rerun-if-env-changed=CARGO_ENCODED_RUSTFLAGS"); | ||
| println!("cargo:rerun-if-env-changed=RUSTC"); |
There was a problem hiding this comment.
I would expect just this line to fix the issue, but having more rerun directives won't hurt anything.
There was a problem hiding this comment.
That might be true. I've now scaled back the list a little to exclude all the cargo features, because those seem less likely to be the problem here, and are more tedious to maintain. Hopefully this works!
sunfishcode
added a commit
that referenced
this pull request
Mar 4, 2023
* Add more `cargo:rerun-if-env-changed`'s to build.rs Add more `cargo:rerun-if-env-changed`'s to build.rs for rustix's features, configuration flags, and the toolchain variables rustix uses for autoconfiguration, to hopefully ensure it gets rerun when anything changes. See also #526. * Don't include all the cargo features.
Merged
sunfishcode
added a commit
that referenced
this pull request
Mar 4, 2023
* Add more `cargo:rerun-if-env-changed`'s to build.rs Add more `cargo:rerun-if-env-changed`'s to build.rs for rustix's features, configuration flags, and the toolchain variables rustix uses for autoconfiguration, to hopefully ensure it gets rerun when anything changes. See also #526. * Don't include all the cargo features.
celinval
added a commit
to celinval/kani-dev
that referenced
this pull request
Mar 8, 2023
After updating our dependencies, running `cargo build-dev` always trigger the recompilation of a few dependencies as well as `kani-driver` and `kani-compiler`. This seems to be caused by [this change](bytecodealliance/rustix#544) on `rustix` dependency. The problem here is that we share the same build folder for our tools and our binaries. But they build with slightly different cargo arguments, and this package decided to make their build script very sensitive to changes to their environment To overcome this, force `cargo build-dev` to use a different folder for the tools build.
4 tasks
celinval
added a commit
to model-checking/kani
that referenced
this pull request
Mar 8, 2023
After updating our dependencies, running `cargo build-dev` always trigger the recompilation of a few dependencies as well as `kani-driver` and `kani-compiler`. This seems to be caused by [this change](bytecodealliance/rustix#544) on `rustix` dependency. The problem here is that we share the same build folder for our tools and our binaries. But they build with slightly different cargo arguments, and this package decided to make their build script very sensitive to changes to their environment To overcome this, force `cargo build-dev` to use a different folder for the tools build.
vlad20012
reviewed
Mar 17, 2023
| println!("cargo:rerun-if-env-changed=CARGO_ENCODED_RUSTFLAGS"); | ||
| println!("cargo:rerun-if-env-changed=RUSTC"); | ||
| println!("cargo:rerun-if-env-changed=TARGET"); | ||
| println!("cargo:rerun-if-env-changed=CARGO_RUSTC_WRAPPER"); |
There was a problem hiding this comment.
It seems like CARGO_RUSTC_WRAPPER is a wrong name. Could you please change it to the proper RUSTC_WRAPPER ?
For reference: dtolnay/anyhow#248
There was a problem hiding this comment.
Good catch! I've now submitted #563 to fix that.
sunfishcode
added a commit
that referenced
this pull request
Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: #544 (comment)
sunfishcode
added a commit
that referenced
this pull request
Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: #544 (comment)
sunfishcode
added a commit
to sunfishcode/io-lifetimes
that referenced
this pull request
Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: bytecodealliance/rustix#544 (comment)
sunfishcode
added a commit
to sunfishcode/io-lifetimes
that referenced
this pull request
Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: bytecodealliance/rustix#544 (comment)
sunfishcode
added a commit
to bytecodealliance/cap-std
that referenced
this pull request
Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: bytecodealliance/rustix#544 (comment)
sunfishcode
added a commit
that referenced
this pull request
Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: #544 (comment)
sunfishcode
added a commit
to bytecodealliance/cap-std
that referenced
this pull request
Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: bytecodealliance/rustix#544 (comment)
sunfishcode
added a commit
to bytecodealliance/cap-std
that referenced
this pull request
Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: bytecodealliance/rustix#544 (comment)
sunfishcode
added a commit
that referenced
this pull request
Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: #544 (comment)
sunfishcode
added a commit
to bytecodealliance/cap-std
that referenced
this pull request
Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: bytecodealliance/rustix#544 (comment)
sunfishcode
added a commit
that referenced
this pull request
Mar 18, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: #544 (comment)
sunfishcode
added a commit
that referenced
this pull request
Oct 12, 2023
* Add more `cargo:rerun-if-env-changed`'s to build.rs Add more `cargo:rerun-if-env-changed`'s to build.rs for rustix's features, configuration flags, and the toolchain variables rustix uses for autoconfiguration, to hopefully ensure it gets rerun when anything changes. See also #526. * Don't include all the cargo features.
sunfishcode
added a commit
that referenced
this pull request
Oct 12, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: #544 (comment)
sunfishcode
added a commit
that referenced
this pull request
Oct 12, 2023
* Add more `cargo:rerun-if-env-changed`'s to build.rs Add more `cargo:rerun-if-env-changed`'s to build.rs for rustix's features, configuration flags, and the toolchain variables rustix uses for autoconfiguration, to hopefully ensure it gets rerun when anything changes. See also #526. * Don't include all the cargo features.
sunfishcode
added a commit
that referenced
this pull request
Oct 12, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: #544 (comment)
sunfishcode
added a commit
that referenced
this pull request
Oct 12, 2023
* Add more `cargo:rerun-if-env-changed`'s to build.rs Add more `cargo:rerun-if-env-changed`'s to build.rs for rustix's features, configuration flags, and the toolchain variables rustix uses for autoconfiguration, to hopefully ensure it gets rerun when anything changes. See also #526. * Don't include all the cargo features.
sunfishcode
added a commit
that referenced
this pull request
Oct 12, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: #544 (comment)
sunfishcode
added a commit
that referenced
this pull request
Oct 12, 2023
* Add more `cargo:rerun-if-env-changed`'s to build.rs Add more `cargo:rerun-if-env-changed`'s to build.rs for rustix's features, configuration flags, and the toolchain variables rustix uses for autoconfiguration, to hopefully ensure it gets rerun when anything changes. See also #526. * Don't include all the cargo features.
sunfishcode
added a commit
that referenced
this pull request
Oct 12, 2023
Similar to dtolnay/anyhow#248, and as suggested [here], check `RUSTC_WRAPPER` instead of `CARGO_RUSTC_WRAPPER`. [here]: #544 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more
cargo:rerun-if-env-changed's to build.rs for rustix's features, configuration flags, and the toolchain variables rustix uses for autoconfiguration, to hopefully ensure it gets rerun when anything changes.See also #526.