Rename rustix_int_0x80 and protect it from multiple definitions.
#1396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In lto builds, multiple versions of the `rustix_int_0x80` assembly code can be included in the same .s file. To avoid conflicts when one of them comes from an older version of rustix, rename the symbol to `rustix_x86_int_0x80`, and to avoid conflicts with future versions, enclose the code in an `ifndef` block. Fixes #1394.
When libc/extra_trais is not enabled, `libc::timespec` does not have a `PartialEq` implementation, so compare the fields directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In lto builds, multiple versions of the
rustix_int_0x80assembly code can be included in the same .s file. To avoid conflicts when one of them comes from an older version of rustix, rename the symbol torustix_x86_int_0x80, and to avoid conflicts with future versions, enclose the code in anifndefblock.Fixes #1394.