Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Correctly zero extend operand of fcvt_from_uint for 8ints and 16bit ints #997

Merged
merged 3 commits into from
Sep 18, 2019

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Sep 7, 2019

Fixes #996

Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for finding and fixing this!

cranelift-codegen/meta/src/shared/legalize.rs Outdated Show resolved Hide resolved
cranelift-codegen/meta/src/shared/legalize.rs Show resolved Hide resolved
cranelift-codegen/src/isa/x86/enc_tables.rs Show resolved Hide resolved
@bjorn3 bjorn3 force-pushed the fix_small_fcvt_from_uint branch from a62fff5 to 43491e5 Compare September 14, 2019 09:01
@bjorn3
Copy link
Contributor Author

bjorn3 commented Sep 14, 2019

Ready for review

@bnjbvr bnjbvr requested a review from sunfishcode September 16, 2019 09:48
Copy link
Member

@sunfishcode sunfishcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bnjbvr bnjbvr merged commit 37a1f06 into bytecodealliance:master Sep 18, 2019
@bjorn3 bjorn3 deleted the fix_small_fcvt_from_uint branch September 18, 2019 08:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fcvt_from_uint for 8bit and 16bit uints is incorrect
3 participants