This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Add hooks for implementing bulk-memory-operations #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
suggested changes
Nov 26, 2019
|
I dropped the two commits that weren't needed. Also I forgot that I should like to the associated SpiderMonkey patch. |
julian-seward1
approved these changes
Dec 4, 2019
bnjbvr
approved these changes
Dec 6, 2019
xeonchen
pushed a commit
to xeonchen/gecko
that referenced
this pull request
Dec 9, 2019
…r=bbouvier Depends on: bytecodealliance/cranelift#1258 This commit adds support for bulk-mem in CL using our builtin methods. The major change is in wasm2clif where I added support for more declarative 'instance calls', and used them for the bulk-mem instructions. Differential Revision: https://phabricator.services.mozilla.com/D54778
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Dec 9, 2019
…r=bbouvier Depends on: bytecodealliance/cranelift#1258 This commit adds support for bulk-mem in CL using our builtin methods. The major change is in wasm2clif where I added support for more declarative 'instance calls', and used them for the bulk-mem instructions. Differential Revision: https://phabricator.services.mozilla.com/D54778 --HG-- extra : moz-landing-system : lando
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Dec 10, 2019
…r=bbouvier Depends on: bytecodealliance/cranelift#1258 This commit adds support for bulk-mem in CL using our builtin methods. The major change is in wasm2clif where I added support for more declarative 'instance calls', and used them for the bulk-mem instructions. Differential Revision: https://phabricator.services.mozilla.com/D54778 UltraBlame original commit: 9129ac29705f517e589fa6232c1987679e0f0e46
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Dec 10, 2019
…r=bbouvier Depends on: bytecodealliance/cranelift#1258 This commit adds support for bulk-mem in CL using our builtin methods. The major change is in wasm2clif where I added support for more declarative 'instance calls', and used them for the bulk-mem instructions. Differential Revision: https://phabricator.services.mozilla.com/D54778 UltraBlame original commit: 9129ac29705f517e589fa6232c1987679e0f0e46
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Dec 10, 2019
…r=bbouvier Depends on: bytecodealliance/cranelift#1258 This commit adds support for bulk-mem in CL using our builtin methods. The major change is in wasm2clif where I added support for more declarative 'instance calls', and used them for the bulk-mem instructions. Differential Revision: https://phabricator.services.mozilla.com/D54778 UltraBlame original commit: 9129ac29705f517e589fa6232c1987679e0f0e46
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have patches that add support for bulk-memory-operations in SpiderMonkey with Cranelift. These commits are the prerequisites for those patches.
The only major change is adding extensibility points to cranelift-wasm for translating bulk-memory-operations. These will be used in SM to translate the operations into function calls which will do the actual work.