Simplify and rename Stackmap::from_vec

[AnthonyMikh]

Functionality is preserved, all tests pass.

It is unclear if this method really should take &Vec<bool> rather than &[bool]. Should I make this change as well?

[bjorn3]

Should I make this change as well?

I think so.

[vitiral]

This is really good code! I like the change from float -> int operations and the use of chunks for the vector. I bet this is more performant too, since it avoids bounds checks.

The only thing is... the method name from_vec is wrong now that it's from a slice instead of a vec 😆

[AnthonyMikh]

@vitiral what name do you propose then? I think about from_bools/from_flags. It shouldn't be a hard change since from_vec is used in this single file only.

[bjorn3]

from_slice?

[AnthonyMikh]

@bjorn3 IMHO, from_slice is not descriptive enough. The fact that argument is slice is already known from types. I suppose that the name should carry a bit more information about the meaning of argument.

[vitiral]

it is a constructor. If there were overloading you would just use from for everything and then overloading would take care of the type. _slice should precisely communicate the type, because it is basically just a stand-in for overloading!

[bnjbvr]

Nice simplification.

[bnjbvr]

Looking great, thanks a lot! It's a sweet simplification.

[bnjbvr]

(I'll squash before merging; in general we try to keep commits "atomic" (= do one logical thing, passes test in isolation) so as to keep git bisection trivial. No worries about not doing so this time, just wanted to let you know for next time :))