adds stubwasi.rs #111
Merged
adds stubwasi.rs #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philrhc
commented
Oct 21, 2024
Comment on lines
-292
to
-294
| if stub_wasi { | ||
| add_wasi_imports(module, &mut wasi_imports)?; | ||
| } |
There was a problem hiding this comment.
i moved this inside the if stub_wasi block below, since looping through the libraries to add libraries is done (again?) there
philrhc
commented
Oct 21, 2024
dicej
reviewed
Oct 21, 2024
philrhc
commented
Oct 28, 2024
| fn add_wasi_imports<'a>( | ||
| module: &'a [u8], | ||
| imports: &mut HashMap<&'a str, HashMap<&'a str, FuncType>>, | ||
| ) -> Result<()> { |
There was a problem hiding this comment.
i'm confused why Result<(), Error> is not required here
There was a problem hiding this comment.
We're useing anyhow::Result, the second generic parameter of which has a default of anyhow::Error, so it doesn't need to be specified explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
factors wasi stubbing out of lib.rs into a new file