Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid overwriting bindings.rs if content is unchanged #346

Merged
merged 1 commit into from
Nov 16, 2024

Conversation

tomasol
Copy link
Contributor

@tomasol tomasol commented Oct 11, 2024

Compare the contents of bindings.rs before overwriting. If no changes are detected, skip the overwrite to prevent unnecessary recompilation.

Compare the contents of `bindings.rs` before overwriting. If no changes
are detected, skip the overwrite to prevent unnecessary recompilation.
@sunfishcode
Copy link
Member

This looks good, and I can confirm that this lets cargo avoid rebuilding entire projects all the time. Thanks!

@sunfishcode sunfishcode enabled auto-merge (squash) November 16, 2024 03:08
@sunfishcode sunfishcode merged commit 0186a82 into bytecodealliance:main Nov 16, 2024
6 checks passed
@tomasol tomasol mentioned this pull request Nov 25, 2024
@sunfishcode
Copy link
Member

This is now released in cargo-component 0.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants