Skip to content

fix(web-ui): override js-yaml to ^4.3.1 (GHSA-5p4m-2wfm-xmqj) - #623

Merged
Weegy merged 1 commit into
mainfrom
fix/js-yaml-ghsa-5p4m
Aug 7, 2026
Merged

fix(web-ui): override js-yaml to ^4.3.1 (GHSA-5p4m-2wfm-xmqj)#623
Weegy merged 1 commit into
mainfrom
fix/js-yaml-ghsa-5p4m

Conversation

@Weegy

@Weegy Weegy commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

What

Pins js-yaml to ^4.3.1 through web-ui's existing overrides block, clearing the high-severity advisory GHSA-5p4m-2wfm-xmqj.

Why

The advisory (quadratic CPU consumption in !!omap resolution; the CVE-2026-59870 fix was not backported) covers 4.0.0 - 4.3.0. web-ui resolves js-yaml@4.3.0 transitively:

eslint@9.39.5 -> @eslint/eslintrc@3.3.6 -> js-yaml@4.3.0

That trips the audit (high+critical block) (web-ui) job. The advisory published after main's last CI run (2026-08-06 09:07 UTC), so main is green only because it has not re-run — every open PR fails this job until it lands. It is not specific to any one branch.

4.3.1 is a patch inside the 4.x line, so eslint itself is untouched. The overrides mechanism is the one already used here for brace-expansion, minimatch and dompurify.

middleware has no js-yaml in its tree at all (npm ls js-yaml → empty) and needs no change — its audit job already passes.

Dev-only dependency: eslint never reaches the shipped bundle. The gate is still repo-wide, which is what makes this blocking.

Test plan

  • npm audit --audit-level=highfound 0 vulnerabilities (was: 1 high)
  • npm ls js-yamljs-yaml@4.3.1 overridden
  • npm run lint → 0 errors (38 pre-existing warnings) — confirms eslint still loads with the patched js-yaml
  • npm run typecheck → clean
  • npm run i18n:check → OK
  • npx vitest run → 584/584 across 71 files

Risk / blast radius

  • Lockfile-only change plus one overrides line: 5 insertions, 4 deletions.
  • No production code, no runtime dependency, no shipped-bundle change.
  • Worst case is an eslint plugin that depended on 4.3.0-specific behaviour; npm run lint passing rules that out.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

The high-severity advisory for quadratic CPU consumption in js-yaml's
!!omap resolution (CVE-2026-59870, not backported) covers 4.0.0 - 4.3.0.
web-ui pulls js-yaml 4.3.0 transitively through
eslint -> @eslint/eslintrc, so the audit gate blocks at high.

Pinned via the existing overrides block, the same mechanism already used
for brace-expansion, minimatch and dompurify. 4.3.1 is a patch inside the
4.x line, so eslint is untouched. middleware has no js-yaml at all and
needs no change.

Dev-only dependency — it never reaches the shipped bundle — but the gate
is repo-wide, so every open PR fails the web-ui audit job until this
lands.
@Weegy
Weegy merged commit 48a74f6 into main Aug 7, 2026
9 checks passed
@Weegy
Weegy deleted the fix/js-yaml-ghsa-5p4m branch August 14, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant