fix(web-ui): override js-yaml to ^4.3.1 (GHSA-5p4m-2wfm-xmqj) - #623
Merged
Conversation
The high-severity advisory for quadratic CPU consumption in js-yaml's !!omap resolution (CVE-2026-59870, not backported) covers 4.0.0 - 4.3.0. web-ui pulls js-yaml 4.3.0 transitively through eslint -> @eslint/eslintrc, so the audit gate blocks at high. Pinned via the existing overrides block, the same mechanism already used for brace-expansion, minimatch and dompurify. 4.3.1 is a patch inside the 4.x line, so eslint is untouched. middleware has no js-yaml at all and needs no change. Dev-only dependency — it never reaches the shipped bundle — but the gate is repo-wide, so every open PR fails the web-ui audit job until this lands.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Pins
js-yamlto^4.3.1through web-ui's existingoverridesblock, clearing the high-severity advisory GHSA-5p4m-2wfm-xmqj.Why
The advisory (quadratic CPU consumption in
!!omapresolution; the CVE-2026-59870 fix was not backported) covers4.0.0 - 4.3.0. web-ui resolvesjs-yaml@4.3.0transitively:That trips the
audit (high+critical block) (web-ui)job. The advisory published after main's last CI run (2026-08-06 09:07 UTC), so main is green only because it has not re-run — every open PR fails this job until it lands. It is not specific to any one branch.4.3.1is a patch inside the 4.x line, so eslint itself is untouched. Theoverridesmechanism is the one already used here forbrace-expansion,minimatchanddompurify.middleware has no
js-yamlin its tree at all (npm ls js-yaml→ empty) and needs no change — its audit job already passes.Dev-only dependency: eslint never reaches the shipped bundle. The gate is still repo-wide, which is what makes this blocking.
Test plan
npm audit --audit-level=high→ found 0 vulnerabilities (was: 1 high)npm ls js-yaml→js-yaml@4.3.1 overriddennpm run lint→ 0 errors (38 pre-existing warnings) — confirms eslint still loads with the patched js-yamlnpm run typecheck→ cleannpm run i18n:check→ OKnpx vitest run→ 584/584 across 71 filesRisk / blast radius
overridesline: 5 insertions, 4 deletions.npm run lintpassing rules that out.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.