Feat/571 mistyped key - #619
Merged
Weegy merged 1 commit intoAug 7, 2026
Merged
Conversation
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Closes #571: a mistyped key_id/agent_id no longer yields a 201 Created dead-but-configured-looking binding. Unknown agent → 400; unknown key → warning; list flags already-dead rows.
Why
Neither id is a foreign key (keys in vault, agents in-process registry, not Postgres), so a typo reached zero tools forever while looking identical to a working binding. Existence is now checked in the app layer against the same sources a real request uses — reusing createVerifyOnlyApiKeyStore, so "known == what the endpoint would accept" by construction. Fail-honest: unreadable source = "cannot tell", never a false reject.
Test plan
Risk / blast radius
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.