fix(ci): grant id-token: write to release.yml's edge-images job - #514
Merged
Conversation
publish-images.yml (the reusable image-publish workflow) declares 'id-token: write' for keyless cosign signing (spec §10), but a reusable workflow cannot self-grant that permission -- the calling job must. auto-release.yml's publish-images job already grants it correctly; the edge-images job in release.yml (push-to-main -> :edge + :sha-<short>) was never updated when that requirement was added, so GitHub rejects the workflow file at parse time with: Error calling workflow '.../publish-images.yml@<sha>'. The workflow is requesting 'id-token: write', but is only allowed 'id-token: none'. This has failed (startup_failure) on every push to main since 2026-07-12 (c627c3c) -- no :edge Docker image has published since. Mirrors the exact permission + comment already used in auto-release.yml's publish-images job.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release.yml'sedge-imagesjob (push-to-main→:edge+:sha-<short>Docker images) calls the reusablepublish-images.ymlworkflow, which requiresid-token: writefor keyless cosign signing (spec §10, added at some point after this job was written). A reusable workflow cannot self-grant that permission — the caller must.edge-imageswas never updated when that requirement landed, whileauto-release.yml's equivalentpublish-imagesjob (for versioned releases) already grants it correctly.Result: GitHub rejects the workflow file at parse time —
Checked all Release-workflow runs on
main: this has beenstartup_failureon every push to main since 2026-07-12 (c627c3c) — 15 days, no:edgeimage has published.Fix
Add
id-token: writetoedge-images'spermissions:block — the exact same line + comment already used inauto-release.yml'spublish-imagesjob (confirmed no other caller ofpublish-images.ymlis missing it).Test plan
auto-release.yml's workingpublish-imagesjob — identical permission setpublish-images.ymlin the repo, both now consistentedge-imagesend-to-end (can't be verified pre-merge sincerelease.ymlonly triggers on push tomain)Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.