chore(profiles): translate German descriptions to English - #47
Merged
Conversation
Picked up from the now-closed #42 — the description-translation half of that PR was missed in my close. The YAML-quoting half of #42 was already folded into PR #44 via #44's commit 0bcb1fd, and the byte5 channel plugin IDs were already in main (only the @omadia/* entries needed quoting for YAML semantics; de.byte5.* don't start with a reserved char). This commit only translates the human-readable description strings — no plugin list changes, no behavioural changes. Tests still green.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picked up from the now-closed #42 — the description-translation half of that PR was missed in my close.
When I closed #42 I noted:
0bcb1fd✅ (correct)byte5channel plugin IDs in OSS profile is problematic — but they were already in main; fix(profile-loader): quote @-plugin ids in YAML and add channel plugins #42 only added quotes (which aren't even needed forde.byte5.*— they don't start with a reserved char). My framing was wrong.Changes
Description-only — no plugin list changes, no behavioural changes. 27/27 profile tests still green.
Refs #42.