fix(ci): bump setup-node to v22 to match middleware engines - #33
Closed
iret77 wants to merge 1 commit into
Closed
Conversation
middleware/package.json declares engines.node ">=22 <23" but .github/workflows/ci.yml pinned setup-node@v4 to node-version "20", which produced EBADENGINE during `npm ci` in the middleware and audit (middleware) jobs once Actions were reactivated.
This was referenced May 17, 2026
Contributor
Author
|
Superseded by #35 (consolidated CI resurrection). Under the strict branch protection with |
4 tasks
Weegy
added a commit
that referenced
this pull request
May 17, 2026
Three CI failures on the consolidation PR: 1. middleware lint+typecheck+test + audit jobs failed with EBADENGINE: workflow ci.yml hardcoded `node-version: '20'` but middleware `package.json` requires `>=22 <23`. Same fix as omadia's unmerged PR #33; applied to all three `setup-node@v4` invocations. 2. Docker build failed with "/docs/harness-platform/boilerplate": not found. The consolidation rsync overwrote omadia's root-level Dockerfile with workshop's version, which references workshop-only paths (`docs/harness-platform/{boilerplate,entity-registry,examples}`, `skills/`, plus a workshop-legacy `services/graph/migrations` COPY). omadia uses `middleware/{assets,plugin-manifests}` instead. Restored the Dockerfile from `main` — has the correct paths, already shipping. 3. web-ui/Dockerfile got similarly overwritten with workshop-specific defaults (hostname `odoo-bot-middleware.internal`, "Harness Admin" comment). Restored from `main` (generic `middleware:8080` default, "Omadia Admin UI" branding).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
middleware/package.jsondeclaresengines.node ">=22 <23", but.github/workflows/ci.ymlpinned all threeactions/setup-node@v4steps tonode-version: '20'.EBADENGINEduringnpm ciin themiddleware (lint + typecheck + test)andaudit (high+critical block) (middleware)jobs.setup-nodeinvocations (middleware job line 44, web-ui job line 78, audit matrix job line 185) from'20'to'22'. No other files touched.Root-level
.nvmrcalready pins22.12.0and was left untouched.The schema-smoke failures (stale migration paths) are out-of-scope here and being handled in a parallel PR.
Test plan
middleware (lint + typecheck + test)andaudit (high+critical block) (middleware)turn green (were red with EBADENGINE).web-ui (lint + typecheck + vitest)andaudit (high+critical block) (web-ui)stay green.schema (migrations on pgvector)remains red until the parallel migration-path PR lands — expected and out-of-scope.