Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add support for setting the prefered Challenge #56

Open
ThaDaVos opened this issue Nov 9, 2024 · 1 comment
Open

Comments

@ThaDaVos
Copy link
Contributor

ThaDaVos commented Nov 9, 2024

Currently it seems the call to Certbot is hardcoded:

certbot_certonly = ('/usr/bin/certbot certonly {acme_server}'
' --standalone'
' --preferred-challenges http'
' --http-01-port 2080'
' --agree-tos'
' --issuance-timeout 90'
' --no-eff-email'
' --non-interactive'
' --max-log-backups=0'
' {eab_kid} {eab_hmac_key}'
' {certs} --email {email}'.format(eab_kid=self.eab_kid,
eab_hmac_key=self.eab_hmac_key,
certs=' '.join(request_certs),
email=self.email,
acme_server=self.acme_server)
)

Could this be opened up so one can configure the parameters on a container basis with labels? In my case, I want to change the preferred challenge from HTTP to DNS and use acme-dns to resolve it:
https://github.com/joohoi/acme-dns
With hook:
https://github.com/koesie10/acme-dns-certbot-hook

ThaDaVos added a commit to ThaDaVos/docker-easy-haproxy that referenced this issue Nov 9, 2024
@ThaDaVos
Copy link
Contributor Author

ThaDaVos commented Nov 9, 2024

Created a PR: #57

ThaDaVos added a commit to ThaDaVos/docker-easy-haproxy that referenced this issue Nov 9, 2024
ThaDaVos added a commit to ThaDaVos/docker-easy-haproxy that referenced this issue Nov 9, 2024
ThaDaVos added a commit to ThaDaVos/docker-easy-haproxy that referenced this issue Nov 9, 2024
ThaDaVos added a commit to ThaDaVos/docker-easy-haproxy that referenced this issue Nov 9, 2024
byjg added a commit that referenced this issue Nov 15, 2024
#56 prototyped manual-auth-hook and different `preferred-challenges` support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant