This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
feat(custom-faker): add map support to custom fakers #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jostillmanns
changed the title
|
Can you resolve the test, please? I think it still errors on Travis 🙏 |
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
- Coverage 94.41% 94.22% -0.19%
==========================================
Files 10 10
Lines 841 849 +8
==========================================
+ Hits 794 800 +6
- Misses 26 27 +1
- Partials 21 22 +1
Continue to review full report at Codecov.
|
obalunenko
reviewed
Jul 26, 2019
| return map[string]interface{}{"foo": "bar"}, nil | ||
| }) | ||
| if err != nil { | ||
| t.Error("Expected NoError, but Got Err", err) |
There was a problem hiding this comment.
suggest failing the test with t.Fatal
| var sample = new(Sample) | ||
| err = FakeData(sample) | ||
| if err != nil { | ||
| t.Error("Expected NoError, but Got Err:", err) |
There was a problem hiding this comment.
suggest failing the test with t.Fatal
bxcodec
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #69