Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Add support for keeping struct property values #64

Merged

Conversation

sebastian-walter
Copy link
Contributor

Sometimes I want to keep the original value of a struct property. Therefore I added a tag keep which allows me to keep the initially set value. It still sets the value if it is the zero value of a field.

@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

Merging #64 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage   94.49%   94.39%   -0.11%     
==========================================
  Files          10       10              
  Lines         799      838      +39     
==========================================
+ Hits          755      791      +36     
- Misses         23       26       +3     
  Partials       21       21
Impacted Files Coverage Δ
faker.go 89.68% <100%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77d6ef...04c005e. Read the comment docs.

@sebastian-walter
Copy link
Contributor Author

@bxcodec Do you know when you have time to look at the PR?

Copy link
Owner

@bxcodec bxcodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sebastian-walter ,
Thank you for the PR, really appreciate it.
And I'm really sorry for the late reply. I'm so busy lately

Overall, it looks good to me.

@bxcodec bxcodec merged commit 342a24f into bxcodec:master Mar 27, 2019
@sebastian-walter
Copy link
Contributor Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants